🌐 Add Korean translation for docs/tutorial/dependencies/classes-as-dependencies.md#9176
Merged
tiangolo merged 19 commits intofastapi:masterfrom Apr 13, 2023
sehwan505:master
Merged
🌐 Add Korean translation for docs/tutorial/dependencies/classes-as-dependencies.md#9176tiangolo merged 19 commits intofastapi:masterfrom sehwan505:master
docs/tutorial/dependencies/classes-as-dependencies.md#9176tiangolo merged 19 commits intofastapi:masterfrom
sehwan505:master
Conversation
Contributor
tiangolo
added
lang-all
NinaHwang
reviewed
Apr 5, 2023
Contributor
NinaHwang
left a comment
NinaHwang
left a comment
There was a problem hiding this comment.
Thank you, @sehwan505 !
Sorry that i was late. Overall it looks great, still I suggest a few changes.
Please review them 🚀
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Co-authored-by: Nina Hwang <[email protected]>
Contributor
hard-coders
approved these changes
Apr 6, 2023
Contributor
hard-coders
left a comment
hard-coders
left a comment
There was a problem hiding this comment.
Sorry for the late 🙇🏻♂️
And thanks @NinaHwang, for the review.
It looks perfect 🚀
joonas-yoon
reviewed
Apr 8, 2023
|
|
||
| <!-- <img src="/img/tutorial/dependencies/image02.png"> --> | ||
|
|
||
| ## 코드 단축 |
Contributor
There was a problem hiding this comment.
Shortcut 을 코드 단축으로 잘 번역해주셨네요. 저는 "줄여서" 정도로 번역하면 어떨 지 한번 제안해봅니다 :)
이 세션의 내용이 단축보다는 생략의 의미가 가까워보여서요.
참고로 다른 문서에서는 shortcut to -를 -하는 쉬운 방법 으로 번역해주신 케이스가 있더라구요.
Contributor
Author
There was a problem hiding this comment.
리뷰 감사합니다. 저는 제목으로는 간단한 단어를 제공하는 게 좋을 것 같아서 위와 같이 적었습니다. 일단은 기조를 유지하되 차후에 이해에 어려움을 겪는 분이 있으시다면 바로 수정해보겠습니다.
Co-authored-by: Joona Yoon <[email protected]>
joonas-yoon
approved these changes
Apr 8, 2023
tiangolo
changed the title
docs/tutorial/dependencies/classes-as-dependencies.md
Member
|
Thanks for your contribution @sehwan505! 🍪 And thanks for the reviews @joonas-yoon, @hard-coders, and @NinaHwang. 🤗 ☕ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.