📝 Update Deta deployment tutorial for compatibility with Deta Space#6004
Merged
tiangolo merged 23 commits intofastapi:masterfrom May 8, 2023
Merged
📝 Update Deta deployment tutorial for compatibility with Deta Space#6004tiangolo merged 23 commits intofastapi:masterfrom
tiangolo merged 23 commits intofastapi:masterfrom
Conversation
Contributor
Contributor
Author
|
WIP / draft |
|
Are there any tests associated with this PR? |
Contributor
Author
|
docs/en/docs/deployment/deta.md
Outdated
|
|
||
| @app.get("/items/{item_id}") | ||
| def read_item(item_id: int): | ||
| print({"item_id": item_id}) |
There was a problem hiding this comment.
Suggested change
| print({"item_id": item_id}) | |
| print({"item_id": item_id}) |
Update deta.md
Contributor
abdelhai
suggested changes
Feb 23, 2023
docs/en/docs/deployment/deta.md
Outdated
| @app.get("/items/{item_id}") | ||
| def read_item(item_id: int): | ||
| async def read_item(item_id: int): | ||
| print({"item_id": item_id}) |
Contributor
Contributor
Contributor
Contributor
discord link
Contributor
Contributor
Contributor
tiangolo
changed the title
Contributor
Contributor
Member
|
Thanks @mikBighne98! 🍰 I tweaked the docs a bit, fixed a couple of things, updated a couple others for consistency, renamed the images to keep the old ones for the translations, and fixed the console outputs, this is ready! 🚀 |
Contributor
Author
|
Thank you for reviewing and merging the PR, @tiangolo 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.