Skip to content

✏️ Update highlighted line in docs/en/docs/tutorial/bigger-applications.md#5490

Merged
alejsdev merged 4 commits intofastapi:masterfrom
papb:patch-2
Jan 11, 2024
Merged

✏️ Update highlighted line in docs/en/docs/tutorial/bigger-applications.md#5490
alejsdev merged 4 commits intofastapi:masterfrom
papb:patch-2

Conversation

@papb
Copy link
Contributor

@papb papb commented Oct 12, 2022

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

📝 Docs preview for commit f598e52 at: https://63473fe4aeb3b90fd9daa586--fastapi.netlify.app

@codecov
Copy link

codecov bot commented Oct 12, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (f598e52) 100.00%.
Report is 988 commits behind head on master.

❗ Current head f598e52 differs from pull request most recent head 5365d11. Consider uploading reports for the commit 5365d11 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #5490   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13969     13934   -35     
=========================================
- Hits         13969     13934   -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

📝 Docs preview for commit 3dec641 at: https://639cdfc9e97dd30578989db8--fastapi.netlify.app

Ryandaydev
Ryandaydev suggested changes Dec 19, 2022
View reviewed changes
Copy link

@Ryandaydev Ryandaydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@papb If I am reading the tutorial correctly, the existing doco incorrectly highlights row 4.

I think instead of this change (which highlights lines 4 & 5), I think it should be changed to highlight row 5.

@papb
Copy link
Contributor Author

papb commented Dec 22, 2022

@Ryandaydev Thank you, you're right. After re-reading I decided to also change another block to highlight one extra line, can you take a look?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

📝 Docs preview for commit e3b590b at: https://63a3ee1a51a71e488d9d9ea1--fastapi.netlify.app

iudeen
iudeen approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice catch!

Ryandaydev
Ryandaydev approved these changes Dec 23, 2022
View reviewed changes
Copy link

@Ryandaydev Ryandaydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes have been applied.

@papb
Copy link
Contributor Author

papb commented Mar 13, 2023

How can I help this PR move forward?

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Oct 2, 2023
@alejsdev alejsdev changed the title Minor docs improvement to bigger-applications.md ✏️ Update highlighted line in docs/en/docs/tutorial/bigger-applications.md Jan 11, 2024
@alejsdev
Copy link
Member

alejsdev commented Jan 11, 2024

Good catch. Thanks @papb 🙂

And thanks for the review @iudeen and @Ryandaydev ✌️

@alejsdev alejsdev enabled auto-merge (squash) January 11, 2024 20:17
@alejsdev alejsdev merged commit d192dda into fastapi:master Jan 11, 2024
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Jan 13, 2024
Sync with fastapi#5490
f72f79d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Ryandaydev Ryandaydev Ryandaydev approved these changes

@iudeen iudeen iudeen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation about how to use FastAPI investigate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@papb @alejsdev @Ryandaydev @iudeen @tiangolo