Skip to content

🌐 Add Korean translation for docs/ko/docs/features.md#5237

Closed
joonas-yoon wants to merge 4 commits intofastapi:masterfrom
joonas-yoon:translate-kor-features
Closed

🌐 Add Korean translation for docs/ko/docs/features.md#5237
joonas-yoon wants to merge 4 commits intofastapi:masterfrom
joonas-yoon:translate-kor-features

Conversation

@joonas-yoon
Copy link
Contributor

@joonas-yoon joonas-yoon commented Aug 5, 2022

Translate the document docs/ko/docs/features.md

related: #2017

This needs to help for some sentences. especially,

  • At line 140, "All the dependencies can require data from requests and augment the path operation constraints and automatic documentation."

Any suggestion?

@codecov
Copy link

codecov bot commented Aug 5, 2022 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ab8988f) compared to base (cf73051).
Patch has no changes to coverable lines.

❗ Current head ab8988f differs from pull request most recent head cb8c3e8. Consider uploading reports for the commit cb8c3e8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #5237    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       533     -7     
  Lines        13969     13725   -244     
==========================================
- Hits         13969     13725   -244
Impacted Files Coverage Δ
tests/main.py 100.00% <0.00%> (ø)
tests/utils.py 100.00% <0.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
tests/test_query.py 100.00% <0.00%> (ø)
fastapi/websockets.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/docs.py 100.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

📝 Docs preview for commit 206bcee at: https://62ed03256dd43648649737a9--fastapi.netlify.app

@joonas-yoon joonas-yoon mentioned this pull request Aug 5, 2022
Closed
joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#5237
2e71504
@tiangolo tiangolo added lang-all Translations awaiting-review lang-ko Korean translations labels Aug 18, 2022
@joonas-yoon joonas-yoon force-pushed the translate-kor-features branch from 206bcee to 85c19e0 Compare August 19, 2022 00:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

📝 Docs preview for commit 85c19e0 at: https://62fed5173202f010b12a5cf0--fastapi.netlify.app

@tiangolo
Copy link
Member

tiangolo commented Jun 26, 2023

📝 Docs preview for commit 3c149c6 at: https://649a11c897baca0e999a9ee5--fastapi.netlify.app

junah201
junah201 reviewed Jul 8, 2023
View reviewed changes
Copy link
Contributor

@junah201 junah201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path operation이 단순히 번역없이 그대로 적혀있는데
하지만 기존에 이미 번역되어 있는 tutorial/first-steps와 tutorial/dependencies/classes-as-dependencies 문서에 경로 동작 이라는 용어로 번역되어 있으므로, 더 적절한 용어를 찾아서 전체 문서를 수정하거나, 경로 동작으로 번역하는게 좋아보입니다.

제 개인적인 생각으로는 경로 동작이라는 용어가 직관적이지 않고 어색하다고 느껴지지만, 더 좋은 용어가 떠오르지 않네요 ㅠ

docs/ko/docs/features.md
- String (`str`) fields, defining min and max lengths.
- Numbers (`int`, `float`) with min and max values, etc.

- 아래와 같은, 외부적인 타입들의 검증도 지원합니다.
Copy link
Contributor

@junah201 junah201 Jul 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 아래와 같은, 외부적인 타입들의 검증도 지원합니다.
- 아래와 같은, 외부 타입들의 검증도 지원합니다.

docs/ko/docs/features.md

- 의존성이 다른 의존성을 갖고 있다면, 의존성 계층 구조나 **의존성 "그래프"** 를 만듭니다.
- 프레임워크에서 전부 **자동으로 처리**됩니다.
- All the dependencies can require data from requests and **augment the path operation** constraints and automatic documentation.
Copy link
Contributor

@junah201 junah201 Jul 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- All the dependencies can require data from requests and **augment the path operation** constraints and automatic documentation.
- 의존성은 requests로부터 데이터를 가져올 수 있으며, **path operation**의 제약 조건을 보완하고 자동 문서화를 추가할 수 있습니다.

@tiangolo
Copy link
Member

tiangolo commented Jan 15, 2024

As this PR had requested changes to be applied but has been inactive for a while, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.

@tiangolo tiangolo closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@junah201 junah201 junah201 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joonas-yoon @tiangolo @junah201