Skip to content

🌐 Add Korean translation for docs/ko/docs/advanced/response-headers.md#4430

Closed
mirusu400 wants to merge 0 commit intofastapi:masterfrom
mirusu400:master
Closed

🌐 Add Korean translation for docs/ko/docs/advanced/response-headers.md#4430
mirusu400 wants to merge 0 commit intofastapi:masterfrom
mirusu400:master

Conversation

@mirusu400
Copy link

@mirusu400 mirusu400 commented Jan 15, 2022

Translates docs/ko/docs/advanced/response-headers.md in Korean.
related: #2017

And just a simple questions:
Why lots of translation PRs are not accepted and not merged? There are 40 Open PRs about Korean translation, but these are not merged.

NinaHwang
NinaHwang reviewed Jan 18, 2022
View reviewed changes
Copy link
Contributor

@NinaHwang NinaHwang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I added some suggestions to keep consistency with the documents that already have been merged.
To answer the question you asked, a PR is not able to be merged until it gets approvals from more than 2 people. It would be a great help if you review & approve others' PR 😊

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Jan 23, 2022
@github-actions github-actions bot mentioned this pull request Jan 23, 2022
Closed
@codecov
Copy link

codecov bot commented Jul 24, 2022 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d7a40cf) compared to base (cf73051).
Patch has no changes to coverable lines.

❗ Current head d7a40cf differs from pull request most recent head 3dfb811. Consider uploading reports for the commit 3dfb811 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #4430    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13684   -285     
==========================================
- Hits         13969     13684   -285
Impacted Files Coverage Δ
tests/main.py 100.00% <0.00%> (ø)
tests/utils.py 100.00% <0.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
tests/test_query.py 100.00% <0.00%> (ø)
fastapi/websockets.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/docs.py 100.00% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2022

📝 Docs preview for commit d7a40cf at: https://62dcce463e02381bac94707c--fastapi.netlify.app

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#4430
e14a801
@mirusu400 mirusu400 closed this Apr 30, 2023
@github-actions github-actions bot temporarily deployed to commit April 30, 2023 14:29 Inactive
@github-actions github-actions bot temporarily deployed to commit April 30, 2023 14:59 Inactive
@github-actions github-actions bot temporarily deployed to commit May 2, 2023 00:45 Inactive
@github-actions github-actions bot temporarily deployed to commit May 2, 2023 00:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hwc9169 hwc9169 hwc9169 left review comments

@NinaHwang NinaHwang NinaHwang left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mirusu400 @hwc9169 @NinaHwang @tiangolo