🌐 Update Korean translation for docs/ko/docs/tutorial/first-steps.md, docs/ko/docs/tutorial/index.md, docs/ko/docs/tutorial/path-params.md, and docs/ko/docs/tutorial/query-params.md#4218
Merged
alejsdev merged 9 commits intofastapi:masterfrom Feb 2, 2024
Conversation
tiangolo
changed the title
docs/ko/docs/tutorial/first-steps.md
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4218 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 540 532 -8
Lines 13969 13672 -297
==========================================
- Hits 13969 13672 -297 ☔ View full report in Codecov by Sentry. |
Contributor
tiangolo
changed the title
docs/ko/docs/tutorial/first-steps.mddocs/ko/docs/tutorial/first-steps.md, docs/ko/docs/tutorial/index.md, docs/ko/docs/tutorial/path-params.md, and docs/ko/docs/tutorial/query-params.md
Member
Member
|
Thanks for your contribution! @SnowSuno 🚀✨ And thanks for the help @NinaHwang 🤓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some translations that doesn't go well with the english docs.
ex)
But when you want to make a query parameter required, you can just not declare any default value:그러나 쿼리 매개변수를 필수로 만들려면 기본값을 선언할 수 없습니다:Which actually means:
그러나 쿼리 매개변수를 필수로 만들려면 단순히 기본값을 선언하지 않으면 됩니다:I also smoothened some awkward translations to make it easier to understand.
Thank you always for your hard work.
related : #2017