Skip to content

🌐 Fix Korean translation for docs/ko/docs/tutorial/security/first-steps.md#4196

Closed
DevDae wants to merge 3 commits intofastapi:masterfrom
DevDae:Fix-first-steps
Closed

🌐 Fix Korean translation for docs/ko/docs/tutorial/security/first-steps.md#4196
DevDae wants to merge 3 commits intofastapi:masterfrom
DevDae:Fix-first-steps

Conversation

@DevDae
Copy link
Contributor

@DevDae DevDae commented Nov 20, 2021

  • Fix Korean translation for docs/ko/docs/tutorial/security/first-steps.md
  • Related [FEATURE] Korean translations Korean translations #2017

If we check 파이썬 한국어 번역 and search the word, "application", it is translated as 응용 프로그램, so we follow the rules of that guide (check of it on #2017 ).

The word "exotic" means "이국적인" in literal translation, but in this sentence, i think "익숙하지 않은" can represent that's meaning more properly.

@DevDae
Copy link
Contributor Author

DevDae commented Nov 20, 2021

I'm waiting for any reviews! 😄
Please check my work and share your idea 🚀

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (915a039) 100.00%.
Report is 1060 commits behind head on master.

❗ Current head 915a039 differs from pull request most recent head aca444f. Consider uploading reports for the commit aca444f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #4196     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       409    -131     
  Lines        13969     10264   -3705     
===========================================
- Hits         13969     10264   -3705     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joonas-yoon
Copy link
Contributor

Hi, this is too late comment.

I supposed that title should be "translation for tutorial/first-steps", not for security.

file changes look good :)

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

As this PR had requested changes to be applied but has been inactive for a while, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.

@tiangolo tiangolo closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants