🌐 Add Korean translation for docs/ko/docs/tutorial/sql-databases.md#4170
🌐 Add Korean translation for docs/ko/docs/tutorial/sql-databases.md#4170NinaHwang wants to merge 9 commits intofastapi:masterfrom
docs/ko/docs/tutorial/sql-databases.md#4170Conversation
Test complete related: fastapi#2017
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4170 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 540 409 -131
Lines 13969 10264 -3705
===========================================
- Hits 13969 10264 -3705 ☔ View full report in Codecov by Sentry. |
DevDae
left a comment
There was a problem hiding this comment.
Appreciate your works!
Please check my review and give your opinions 😄
Thanks 🚀
Co-authored-by: daehyeon kim <[email protected]>
Co-authored-by: daehyeon kim <[email protected]>
Co-authored-by: daehyeon kim <[email protected]>
Co-authored-by: daehyeon kim <[email protected]>
docs/tutorial/sql-databases.mddocs/ko/docs/tutorial/sql-databases.md
|
Thank you! I'm still waiting for others to review this to be able to merge it, meanwhile, maybe you could help me review some of the other Korean translations, that way if they are approved by each other, I could merge them. 🤓 Maybe @DevDae could review again after the requested changes? 🙏 |
|
I wanted to re-write the SQL docs with SQLModel, I just finished that here: #12285 The new docs are here: https://fastapi.tiangolo.com/tutorial/sql-databases/ That also means this PR is based on a version that no longer exists. 😅 Given that, I'll pass on this one, but thanks for the effort! 🍰 |
This PR translates tutorial/sql-databases.md in Korean.
related: #2017