Skip to content

🌐 Add Korean translation for docs/ko/docs/tutorial/sql-databases.md#4170

Closed
NinaHwang wants to merge 9 commits intofastapi:masterfrom
NinaHwang:tutorial/sql-databases
Closed

🌐 Add Korean translation for docs/ko/docs/tutorial/sql-databases.md#4170
NinaHwang wants to merge 9 commits intofastapi:masterfrom
NinaHwang:tutorial/sql-databases

Conversation

@NinaHwang
Copy link
Contributor

This PR translates tutorial/sql-databases.md in Korean.

related: #2017

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (0b301ae) 100.00%.

❗ Current head 0b301ae differs from pull request most recent head d21f758. Consider uploading reports for the commit d21f758 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #4170     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       409    -131     
  Lines        13969     10264   -3705     
===========================================
- Hits         13969     10264   -3705     

see 177 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Copy link
Contributor

@DevDae DevDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your works!
Please check my review and give your opinions 😄
Thanks 🚀

@github-actions
Copy link
Contributor

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@NinaHwang NinaHwang requested a review from DevDae December 19, 2022 08:03
@tiangolo tiangolo changed the title 🌐 Add Korean translation for docs/tutorial/sql-databases.md 🌐 Add Korean translation for docs/ko/docs/tutorial/sql-databases.md Jun 26, 2023
@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

Thank you! I'm still waiting for others to review this to be able to merge it, meanwhile, maybe you could help me review some of the other Korean translations, that way if they are approved by each other, I could merge them. 🤓

https://github.com/tiangolo/fastapi/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Alang-ko+label%3Aawaiting-review

Maybe @DevDae could review again after the requested changes? 🙏

@tiangolo
Copy link
Member

tiangolo commented Oct 9, 2024

I wanted to re-write the SQL docs with SQLModel, I just finished that here: #12285

The new docs are here: https://fastapi.tiangolo.com/tutorial/sql-databases/

That also means this PR is based on a version that no longer exists. 😅

Given that, I'll pass on this one, but thanks for the effort! 🍰

@tiangolo tiangolo closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants