Skip to content

🌐 Add Korean translation for docs/benchmarks.md#4142

Closed
kimjaeyoonn wants to merge 10 commits intofastapi:masterfrom
kimjaeyoonn:ko/docs/benchmarks.md
Closed

🌐 Add Korean translation for docs/benchmarks.md#4142
kimjaeyoonn wants to merge 10 commits intofastapi:masterfrom
kimjaeyoonn:ko/docs/benchmarks.md

Conversation

@kimjaeyoonn
Copy link
Contributor

@kimjaeyoonn kimjaeyoonn commented Nov 4, 2021

I'm posting a new PR because there are a few things that need to be corrected through feedback.
Thank you 😆

Add Korean translation for ko/docs/benchmarks.md
Related [FEATURE] Korean translations [FEATURE] Korean translations [FEATURE] Korean translations #2017

@kimjaeyoonn kimjaeyoonn changed the title 🌐 Add Korean translation for docs/benchmarks.md 🌐 Add Korean translation for docs/benchmarks.md Nov 4, 2021
DongwonGim
DongwonGim reviewed Nov 4, 2021
View reviewed changes
Copy link

@DongwonGim DongwonGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starlette 및 Uvicorn보다 낮습니다.
->
Starlette과 Uvicorn 다음으로 높은 순위입니다.

0417taehyun
0417taehyun suggested changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@0417taehyun 0417taehyun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is my mistake 😭

@kimjaeyoonn
Copy link
Contributor Author

kimjaeyoonn commented Nov 17, 2021

I have accepted the feedback. Thank you @0417taehyun 😆
And I'm sure there are no more problems with the translation of this document.

@tiangolo I think you can merge this PR :)

@kimjaeyoonn
Update benchmarks.md
e476199 
@DongwonGim    
I have accepted your feedback. Thankyou 🚀

@tiangolo
I hope you merge this document.
There are many documents still open in #2017. 
I'm curious as to why it can't be merged. 
Even if it's not perfect, if you merge it, it will be easier for people to find parts to fix on the FastAPI webpage, so please merge it.
@kimjaeyoonn
Copy link
Contributor Author

kimjaeyoonn commented Nov 18, 2021

@DongwonGim
I have accepted your feedback. Thankyou 🚀

@tiangolo
I hope you merge this document.
There are many documents still open in #2017.
I'm curious as to why it can't be merged.
Even if it's not perfect, if you merge it, it will be easier for people to find parts to fix on the FastAPI webpage, so please merge it.

DevDae
DevDae approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@DevDae DevDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I review all works and check there is nothing to revise!
Appreciate you, @kimjaeyoonn 🚀

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
Closed
@tiangolo
Copy link
Member

tiangolo commented Dec 8, 2021

Thanks for the contribution @kimjaeyoonn! As I don't speak the language, I merge translation PRs after they have 2 approving reviews. 🤓

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#4142
9c2b43f
@kimjaeyoonn kimjaeyoonn closed this by deleting the head repository Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@DongwonGim DongwonGim DongwonGim left review comments

@0417taehyun 0417taehyun 0417taehyun requested changes

@DevDae DevDae DevDae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kimjaeyoonn @tiangolo @DongwonGim @0417taehyun @DevDae