Skip to content

🌐 Fix Korean translation for docs/ko/docs/tutorial/first-steps.md#3171

Closed
SueNaEunYang wants to merge 1 commit intomasterfrom
unknown repository
Closed

🌐 Fix Korean translation for docs/ko/docs/tutorial/first-steps.md#3171
SueNaEunYang wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@SueNaEunYang
Copy link
Contributor

@SueNaEunYang SueNaEunYang commented May 4, 2021

Hello, I carefully pulled a request on the already uploaded page.
While I was quickly going through the docs to study, I found out a few trivial points to suggest. Please take a look if there's any part you like.

Here are what I suggested :

  • corrected a trivial typo
  • changed the tone that suit Korean translations #2017
  • suggested some alternatives that seem to be closer to the author's original intent.

Plus, I have one thing to ask for your opinion. I personally think that putting the original terminoloy right after the translated word inside the parentheses seems to be a good way to reduce confusion for Korean readers. I am asking this because I saw some of your reviews on other PRs removing those English versions in parentheses, and still having the one within this file (동작(operation) <- this one).
If there's any translation guide on this matter, I would be very grateful if you let me know :)

Thanks always for your contributions and efforts!!

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #3171 (b305403) into master (ce0ec06) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2252837...b305403. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels May 6, 2021
@DevDae DevDae mentioned this pull request Oct 9, 2021
@0417taehyun
Copy link
Contributor

I think it would be better to remove the supplementary explanation by using () like you said, (operation) because if we accept that rules there are so many things to write.

Also, we follow the rules 격칙체 (check in #2017 ) so it is right to use -기 바립니다. or -십시오 instead of -세요..

I agree to translate the docs to be closer to the author's original intent, however if you want to discuss it, I think it would be better to add your opinion in #3167 !

@tiangolo tiangolo changed the title 🌐 Fix Korean translation for Tutorial - First Steps 🌐 Fix Korean translation for docs/ko/docs/tutorial/first-steps.md Jun 26, 2023
@tiangolo
Copy link
Member

As this is quite old and it seems it's not necessarily agreed to follow with these changes, I'll pass on this one, but thanks for the effort @SueNaEunYang! ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants