Skip to content

🌐 Add Korean translation for docs/ko/docs/tutorial/static-files.md#2957

Merged
alejsdev merged 9 commits intofastapi:masterfrom
jeesang7:ko/tutorial/static-files
Jan 22, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/tutorial/static-files.md#2957
alejsdev merged 9 commits intofastapi:masterfrom
jeesang7:ko/tutorial/static-files

Conversation

@jeesang7
Copy link
Contributor

This is my first PR translates tutorial/static-files.md in Korean.
Frankly, I'm not used to it yet, so I chose the part that I know well and don't feel pressured.
Please review the translation, thanks.

안녕하세요, 이렇게 번역 기여에 참여하게 되어 기쁩니다.
비록 많이 부족하고 양도 적지만, 조금이라도 도움이 되고 싶어 PR 올립니다.
어색하거나 이견이 있으시면 피드백 부탁드립니다. 감사합니다.

related: #2017

@github-actions
Copy link
Contributor

@ArcLightSlavik
Copy link
Contributor

Could you change the name of PR to "Japanese translation for tutorial/static-files.md"

@jeesang7 jeesang7 changed the title 🌐 translate tutorial/static-files.md 🌐 Korean translation for tutorial/static-files.md Mar 17, 2021
@jeesang7
Copy link
Contributor Author

jeesang7 commented Mar 17, 2021

Could you change the name of PR to "Japanese translation for tutorial/static-files.md"

Yes. But it's not Japanese, this is Korean.

@github-actions
Copy link
Contributor

Copy link

@akagaeng akagaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

살짝 자연스럽게 다듬어 봤습니다 :)

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@jeesang7
Copy link
Contributor Author

살짝 자연스럽게 다듬어 봤습니다 :)

훨씬 자연스러운 것 같습니다 😄

@tiangolo tiangolo changed the title 🌐 Korean translation for tutorial/static-files.md 🌐 Korean translation for Tutorial - Static Files Mar 27, 2021
@tiangolo tiangolo changed the title 🌐 Korean translation for Tutorial - Static Files 🌐 Add Korean translation for Tutorial - Static Files Mar 27, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Mar 27, 2021
@hard-coders hard-coders mentioned this pull request May 11, 2021
Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big appreciate of your works and great honor to check it.

Feel free to check my reviews 🚀

I think the aiofiles section was deprecated so please update (fetch) the your file to the latest version.


### "마운팅" 이란

"마운팅"은 특정 경로에 완전한 "독립적인" 애플리케이션을 추가하는 것을 말하는데, 그 후에는 모든 하위 경로에 대해서도 적용됩니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"마운팅"은 특정 경로에 완전한 "독립적인" 애플리케이션을 추가하는 것을 말하는데, 그 후에는 모든 하위 경로에 대해서도 적용됩니다.
"마운팅"은 특정 경로에 완전히 "독립적인" 응용 프로그램을 추가하는 것을 의미하는데, 그 모든 하위 경로에 대해서도 적용됩니다.

@jeesang7 jeesang7 force-pushed the ko/tutorial/static-files branch from c1e8c50 to 837ba32 Compare November 7, 2021 07:31
@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Static Files 🌐 Add Korean translation for docs/ko/docs/tutorial/static-files.md Jun 26, 2023
@tiangolo
Copy link
Member

change `애플리케이션` to `응용 프로그램`

Co-authored-by: weekwith.me <[email protected]>
@tiangolo
Copy link
Member

Copy link

@akagaeng akagaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alejsdev alejsdev merged commit ea6e0ff into fastapi:master Jan 22, 2024
@alejsdev
Copy link
Member

Thanks for your contribution! @jeesang7 😃

And thanks for the review @akagaeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants