Skip to content

🌐 Add Korean translation for docs/ko/docs/tutorial/cookie-params.md#2545

Closed
hard-coders wants to merge 2 commits intofastapi:masterfrom
hard-coders:ko/tutorial/cookie-params
Closed

🌐 Add Korean translation for docs/ko/docs/tutorial/cookie-params.md#2545
hard-coders wants to merge 2 commits intofastapi:masterfrom
hard-coders:ko/tutorial/cookie-params

Conversation

@hard-coders
Copy link
Contributor

@hard-coders hard-coders commented Dec 20, 2020

This PR translates tutorial/cookie-params.md in Korean.

related: #2017

@codecov
Copy link

codecov bot commented Dec 20, 2020 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (fd70830) 100.00%.
Report is 1056 commits behind head on master.

❗ Current head fd70830 differs from pull request most recent head d049d59. Consider uploading reports for the commit d049d59 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #2545     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       242    -298     
  Lines        13969      7396   -6573     
===========================================
- Hits         13969      7396   -6573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2020

📝 Docs preview for commit fd70830 at: https://5fdf056a714dafd4e92c5b6b--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Jan 5, 2021
PandaHun
PandaHun approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@PandaHun PandaHun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect done

@hard-coders hard-coders mentioned this pull request May 11, 2021
Closed
0417taehyun
0417taehyun suggested changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit appreciate of your works 🚀

For solving some conflicts, can you update this file to latest version?

Feel free to check my reviews, it is just a SIMPLE thing.

docs/ko/docs/tutorial/cookie-params.md
{!../../../docs_src/cookie_params/tutorial001.py!}
```

!!! note "기술 세부사항"
Copy link
Contributor

@0417taehyun 0417taehyun Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!!! note "기술 세부사항"
!!! note "기술적 세부사항"

Check 파이썬 공식 한국어 문서에 없는 용어 중 현재 사용하고 있는 용어

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#2545
f9d5ea5
@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Cookie Parameters 🌐 Add Korean translation for docs/ko/docs/tutorial/cookie-params.md Jun 26, 2023
@tiangolo
Copy link
Member

tiangolo commented Jun 26, 2023

📝 Docs preview for commit d049d59 at: https://6499e2be5f77290548b8a60d--fastapi.netlify.app

@tiangolo
Copy link
Member

tiangolo commented Jan 15, 2024

As this PR had requested changes to be applied but has been inactive for a while, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.

@tiangolo tiangolo closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@0417taehyun 0417taehyun 0417taehyun requested changes

@PandaHun PandaHun PandaHun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hard-coders @tiangolo @PandaHun @0417taehyun