Skip to content

🌐 Add Korean translation for docs/ko/docs/tutorial/body-multiple-params.md#2461

Merged
alejsdev merged 6 commits intofastapi:masterfrom
PandaHun:ko/tutorial/body_multiple_parameters
Jan 22, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/tutorial/body-multiple-params.md#2461
alejsdev merged 6 commits intofastapi:masterfrom
PandaHun:ko/tutorial/body_multiple_parameters

Conversation

@PandaHun
Copy link
Contributor

@PandaHun PandaHun commented Dec 3, 2020

This PR translates tutorial/body-multiple-params.md in Korean

related: #2017

@codecov
Copy link

codecov bot commented Dec 3, 2020 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (f13d74b) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head f13d74b differs from pull request most recent head c6130d2. Consider uploading reports for the commit c6130d2 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #2461     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       242    -298     
  Lines        13969      7396   -6573     
===========================================
- Hits         13969      7396   -6573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PandaHun
Copy link
Contributor Author

PandaHun commented Dec 3, 2020 •
edited
Loading

Would it be better to translate body to 본문 or leave it body?
Body를 그대로 Body로 둘지, 본문으로 번역 할 지에 대한 의견 부탁드립니다.

@hard-coders
Copy link
Contributor

hard-coders commented Dec 4, 2020

Would it be better to translate body to 본문 or leave it body?
Body를 그대로 Body로 둘지, 본문으로 번역 할 지에 대한 의견 부탁드립니다.

I prefer 본문 to 바디 because

  • latter is not translated
  • all translation PR(including not merged) use latter
  • former has more appeared in MDN Korean docs (both are used, though 🧐)

It is just a personal opinion, but I think you(@PandaHun) should leave them. 😃

hard-coders
hard-coders reviewed Dec 4, 2020
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2020

📝 Docs preview for commit 96dc082 at: https://5fcd8b70f7ef2c709e108381--fastapi.netlify.app

hard-coders
hard-coders approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 Thanks for your contribution! I think it's almost done!

hard-coders
hard-coders approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice work!
BTW, you could commit directly on Github by accepting reviews, and Github will approve it automatically when a reviewer approved with suggestions.
Otherwise, the reviewer has to approve it again.😂

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 19, 2020
@hard-coders hard-coders mentioned this pull request May 11, 2021
Closed
joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#2461
5d6a184
@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Body Multiple Parameters 🌐 Add Korean translation for docs/ko/docs/tutorial/body-multiple-params.md Jun 26, 2023
@tiangolo
Copy link
Member

tiangolo commented Jun 26, 2023

📝 Docs preview for commit c6130d2 at: https://6499c97e1d7654037c04dcaa--fastapi.netlify.app

@alejsdev alejsdev merged commit 83944b9 into fastapi:master Jan 22, 2024
@alejsdev
Copy link
Member

alejsdev commented Jan 22, 2024

Thanks for your contribution! @PandaHun 👨‍💻

And thanks for the review @hard-coders 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hard-coders hard-coders hard-coders approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PandaHun @hard-coders @tiangolo @alejsdev