🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md#2415
Merged
alejsdev merged 20 commits intofastapi:masterfrom Jan 22, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2415 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 540 532 -8
Lines 13969 13684 -285
==========================================
- Hits 13969 13684 -285 ☔ View full report in Codecov by Sentry. |
Contributor
Closed
0417taehyun
suggested changes
Nov 5, 2021
|
|
||
| 이제는 더이상 이 매개변수를 마음에 들어하지 않는다고 가정해 봅시다. | ||
|
|
||
| 이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다. |
Contributor
There was a problem hiding this comment.
Suggested change
| 이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다. | |
| 이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다</abbr>고 확실하게 문서에서 보여주고 싶습니다. |
Contributor
Author
There was a problem hiding this comment.
Deprecated means "it will be not used in near future". So I left the original word, deprecated.
How about
Suggested change
| 이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다. | |
| 이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않을 예정이다</abbr>라고 확실하게 문서에서 보여주고 싶습니다. |
kty4119
approved these changes
Nov 21, 2021
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Contributor
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Co-authored-by: weekwith.me <[email protected]>
Contributor
Co-authored-by: weekwith.me <[email protected]>
Contributor
Author
|
Thanks to @kty4119 and especially @0417taehyun :D |
Contributor
Contributor
joonas-yoon
added a commit
to joonas-yoon/fastapi
that referenced
this pull request
Aug 6, 2022
docs/ko/docs/tutorial/query-params-str-validations.md
Member
Member
|
Thanks for your work @hard-coders 🪄 And thanks for the reviews @kty4119 and @0417taehyun 🤓✌️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR translates
tutorial/query-params-str-validations.mdin Korean.related: #2017