Skip to content

🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md#2415

Merged
alejsdev merged 20 commits intofastapi:masterfrom
hard-coders:ko/tutorial/query-params-str-validation
Jan 22, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md#2415
alejsdev merged 20 commits intofastapi:masterfrom
hard-coders:ko/tutorial/query-params-str-validation

Conversation

@hard-coders
Copy link
Contributor

This PR translates tutorial/query-params-str-validations.md in Korean.

related: #2017

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (3628921) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head 3628921 differs from pull request most recent head 238ab81. Consider uploading reports for the commit 238ab81 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #2415    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13684   -285     
==========================================
- Hits         13969     13684   -285     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Nov 25, 2020
@hard-coders hard-coders mentioned this pull request May 11, 2021
Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big appreciate of you works and great honor to check it.

Feel free to check my reviews 🚀

Also, please update (fetch) your files to latest version to solve the conflicts


이제는 더이상 이 매개변수를 마음에 들어하지 않는다고 가정해 봅시다.

이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다.
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다</abbr>고 확실하게 문서에서 보여주고 싶습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated means "it will be not used in near future". So I left the original word, deprecated.
How about

Suggested change
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr> 확실하게 문서에서 보여주고 싶습니다.
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않을 예정이다</abbr>라고 확실하게 문서에서 보여주고 싶습니다.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@hard-coders
Copy link
Contributor Author

Thanks to @kty4119 and especially @0417taehyun :D

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Query Parameters and String Validations 🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md Jun 26, 2023
@tiangolo
Copy link
Member

@tiangolo tiangolo requested a review from 0417taehyun January 15, 2024 15:51
@alejsdev alejsdev merged commit 87a4c9e into fastapi:master Jan 22, 2024
@alejsdev
Copy link
Member

Thanks for your work @hard-coders 🪄

And thanks for the reviews @kty4119 and @0417taehyun 🤓✌️

@hard-coders hard-coders deleted the ko/tutorial/query-params-str-validation branch January 23, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants