Skip to content

🌐 Add Korean translation for docs/ko/docs/python-types.md#2267

Merged
alejsdev merged 30 commits intofastapi:masterfrom
jrim:translation/ko
Jan 22, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/python-types.md#2267
alejsdev merged 30 commits intofastapi:masterfrom
jrim:translation/ko

Conversation

@jrim
Copy link
Contributor

@jrim jrim commented Oct 30, 2020 •
edited
Loading

Korean translated 'python-types.md' #2017

@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (d2a0e65) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head d2a0e65 differs from pull request most recent head 655e68d. Consider uploading reports for the commit 655e68d to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #2267     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       240    -300     
  Lines        13969      7101   -6868     
===========================================
- Hits         13969      7101   -6868

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrim jrim changed the title Add Korean Translation for Python-types #2017 Add Korean Translation for Python-types Oct 30, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2020

📝 Docs preview for commit eb3ac10 at: https://5f9bd3234b8985d7301987f1--fastapi.netlify.app

@jrim jrim changed the title Add Korean Translation for Python-types Add Korean Translation for python-types.md Oct 30, 2020
hard-coders
hard-coders reviewed Nov 6, 2020
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated #2017 a few days ago. I want you to follow it.
Sorry for the late update.😭

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2020

📝 Docs preview for commit d2a0e65 at: https://5fa53daa31aca1ff592e3b27--fastapi.netlify.app

hard-coders
hard-coders reviewed Nov 7, 2020
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost there!😎

But there's one more thing... to do. Please replace "에디터" with "편집기". It is also to follow python's official Korean docs.

hard-coders
hard-coders reviewed Nov 7, 2020
View reviewed changes
hard-coders
hard-coders reviewed Nov 7, 2020
View reviewed changes
SueNaEunYang
SueNaEunYang reviewed May 4, 2021
View reviewed changes
Copy link
Contributor

@SueNaEunYang SueNaEunYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your efforts.
I added some comments here.
I hope they can be of any help for you :)

docs/ko/docs/python-types.md
```

!!! info
Pydantic<에 대해 더 배우고 싶다면 <a href="https://pydantic-docs.helpmanual.io/" class="external-link" target="_blank">공식 문서</a>를 참고하세요.</a>
Copy link
Contributor

@SueNaEunYang SueNaEunYang May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "참고하십시오/확인해보십시오." rather than "참고하세요." ?

jrim and others added 11 commits May 4, 2021 21:04
@jrim @SueNaEunYang
Update docs/ko/docs/python-types.md
d4bdc81 
Co-authored-by: SueNaeunYang <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
efe4f2c 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
79adb0e 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
698665e 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
e646215 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
e596484 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
2e4f16d 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
c3df2b7 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
d5f04dc 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
f8f5c46 
Co-authored-by: Spike <[email protected]>
@jrim @hard-coders
Update docs/ko/docs/python-types.md
a214848 
Co-authored-by: Spike <[email protected]>
jrim and others added 8 commits May 4, 2021 21:06
@jrim
Copy link
Contributor Author

jrim commented May 4, 2021 •
edited
Loading

Thanks for reviewing y'all

hard-coders
hard-coders reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed some lines more, like

!!! tip

to

!!! tip "팁"

Please see reviews and modify what you can accept.
I hope this PR merged soon:D

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#2267
30c253a
@tiangolo tiangolo changed the title Add Korean Translation for python-types.md 🌐 Add Korean Translation for docs/ko/docs/python-types.md Jun 26, 2023
@tiangolo tiangolo changed the title 🌐 Add Korean Translation for docs/ko/docs/python-types.md 🌐 Add Korean translation for docs/ko/docs/python-types.md Jun 26, 2023
@tiangolo
Copy link
Member

tiangolo commented Jun 26, 2023

📝 Docs preview for commit 655e68d at: https://6499cd5a4a964606cbd74e3b--fastapi.netlify.app

hard-coders
hard-coders approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been forgotten for a long time, so the Type Hints with Metadata Annotations section isn't reflected in this PR. Despite the problem, because it is well-translated, I approve it and will create a new pull request to add the section.

I'm sorry for not getting back to it sooner. 🙇🏻

@alejsdev alejsdev merged commit 2a8f8d1 into fastapi:master Jan 22, 2024
@alejsdev
Copy link
Member

alejsdev commented Jan 22, 2024

Thank you! @jrim 🐱

And thanks for the reviews @hard-coders and @SueNaEunYang 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SueNaEunYang SueNaEunYang Awaiting requested review from SueNaEunYang

1 more reviewer

@hard-coders hard-coders hard-coders approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-1 hacktoberfest-accepted lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jrim @tiangolo @alejsdev @hard-coders @SueNaEunYang