Add support for adding OpenAPI schema for GET requests with a body#1626
Merged
tiangolo merged 4 commits intofastapi:masterfrom Jul 19, 2020
Merged
Add support for adding OpenAPI schema for GET requests with a body#1626tiangolo merged 4 commits intofastapi:masterfrom
tiangolo merged 4 commits intofastapi:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1626 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 227 239 +12
Lines 6810 7047 +237
==========================================
+ Hits 6810 7047 +237
Continue to review full report at Codecov.
|
Contributor
Author
|
@IamCathal could you take a look at this? |
rkbeatss
reviewed
Jun 25, 2020
Contributor
There was a problem hiding this comment.
@victorphoenix3 i think this is where the coverage is missing so try adding # pragma: no cover here
victorphoenix3
force-pushed
the
get
branch
3 times, most recently
from
f416e25 to
065be3c
Compare
Contributor
Author
|
@tiangolo The PR is ready for review. |
9 tasks
tiangolo
changed the title
Member
|
Awesome @victorphoenix3 ! 🚀 🎉 I updated the test to check that it actually can receive a body in a Thanks for your contribution! 🍰 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #713 .