ποΈ Add zizmor and fix audit findings#15316
Merged
Conversation
Contributor
π Docs previewLast commit bb712e1 at: https://e50d6899.fastapitiangolo.pages.dev |
This comment was marked as resolved.
This comment was marked as resolved.
tiangolo
approved these changes
Apr 16, 2026
Member
tiangolo
left a comment
There was a problem hiding this comment.
Excellent, looks great! π Thanks! π
|
Few suggestions to reduce tech debt:
This makes handling new zizmor checks simpler. If you prefer, I can make the changes and draft a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes changes from #15261 . So, if this PR gets merged, #15261 may be closed.
Changes applied:
dangerous-triggersrule forpull_request_targetandworkflow_run(checked that they are used in a safe way)secrets-outside-envrule as using the environments would require approval for each run (and without required approvals it wouldn't make sense)persist-credentials: falseforactions/checkoutwhen persisting is not needed by other stepsuvto install forastral-sh/setup-uv(Note that Dependabot will not upgrade it, but Renovate can do it)template-injectionrule when input comes from trusted source (workflow_dispatchorschedule)template-injectionin other casesuvhas internal defense mechanism against cache poisoninglatest-changesto make it clear that it only runs for merged PRsuvx prekcommand withuv run prek-uvxuses latest version (unpinned), it's better to use locked versionnotify-translations- it's recommended practice forpull_request_targettriggers and in this case it shouldn't break anything