🔨 Tweak translation workflow and translation fixer tool#15166
Merged
🔨 Tweak translation workflow and translation fixer tool#15166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes 2 fixes:
1. Don't fail if translation doesn't pass validation (just save it and continue with next page)
When translation script fails to translate page after 3 attempts (results fails to pass validation), it currently causes the workflow to fail. So, we are missing all data processed by that moment..
We can actually just skip it and fix this page later manually.
2. Forbid whitespace before attributes in markdown link pattern
The line above currently mathches two patterns: header permalink and markdown link with parameters.
This causes problems - translation fixer tool treats it as link and removes whitespace, then it fails with "Number of permalinks doesn't match.."
Updated pattern of markdown link to not allow that whitespace