Conversation
Merging this PR will not alter performance
Comparing 
|
Contributor
📝 Docs previewLast commit a754bc1 at: https://04445945.fastapitiangolo.pages.dev |
…st=loadgroup` option)
YuriiMotov
force-pushed
the
xdist
branch
2 times, most recently
from
fe938ee to
7365d6f
Compare
YuriiMotov
force-pushed
the
xdist
branch
4 times, most recently
from
98e1855 to
7b4460b
Compare
YuriiMotov
commented
Feb 25, 2026
YuriiMotov
commented
Feb 25, 2026
YuriiMotov
commented
Feb 25, 2026
tiangolo
approved these changes
Feb 27, 2026
Member
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Awesome! Thanks a lot, great and thorough job. 🙌
Testing everything locally for me went form 2m15s to 1m37s 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests run x2.3 faster (locally): 18s VS 42s.
The drawback is that it's easy to introduce race condition. We need to be careful and mark tests that modify files in working directory with
@workdir_lockdecorator introduced in this PR.To make it easier to debug race conditions, I added
pytest-timeoutplugin.Stress-tested with
-n 50- adjusted pytest timeout as a result (5->20).After all adjustments, 10 runs passed ✅
Note: I added
test-cov.shscript and moved--cov --cov-context=testto it. This way when we run justtest.shit works much faster (doesn't store coverage data).Inline snapshot gives the following:
To update inline snapshots we can run tests as
bash scripts/test.sh -n 0