👷 Do not run codspeed with coverage as it's not tracked#14966
Merged
👷 Do not run codspeed with coverage as it's not tracked#14966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👷 Do not run codspeed with coverage as it's not tracked
This is done as a PR independent from #14965 to clearly isolate the fake "performance improvement" reported in the comment below.
The speed up in this PR is just because it's not running everything through coverage but running it directly, so it doesn't really count.
Performance improvements in previous PRs do count, as the code before and after changes was run through coverage in both cases, so the coverage overhead was the same. In fact, previous performance improvements were probably much higher than estimated, as coverage would account for a lot of the overhead.
This PR is made isolated apart so that it's clear when it's the change in how performance is measured (with and without coverage).
Future improvements will be measured against this new baseline without coverage taking overhead.