✏️ Fix typo for client_secret in OAuth2 form docstrings#14946
Merged
svlandeg merged 1 commit intofastapi:masterfrom Mar 24, 2026
Merged
✏️ Fix typo for client_secret in OAuth2 form docstrings#14946svlandeg merged 1 commit intofastapi:masterfrom
client_secret in OAuth2 form docstrings#14946svlandeg merged 1 commit intofastapi:masterfrom
Conversation
bysiber
force-pushed
the
fix/client-password-typo-oauth2
branch
from
f562377 to
2c09b63
Compare
svlandeg
approved these changes
Mar 24, 2026
svlandeg
changed the title
client_password typo in OAuth2 form docstringsclient_secret in OAuth2 form docstrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
client_secretparameter docstring in bothOAuth2PasswordRequestFormandOAuth2PasswordRequestFormStrictincorrectly referred toclient_passwordinstead ofclient_secret.The parameter itself is correctly named
client_secret, and the rest of each docstring also usesclient_secret— it's just this one mention that had the wrong name.