Skip to content

📝 Fix doctrings for max_digits and decimal_places#14944

Merged
svlandeg merged 1 commit intomasterfrom
fix-max_digits-docstring
Mar 4, 2026
Merged

📝 Fix doctrings for max_digits and decimal_places#14944
svlandeg merged 1 commit intomasterfrom
fix-max_digits-docstring

Conversation

@YuriiMotov
Copy link
Copy Markdown
Member

@YuriiMotov YuriiMotov added the docs Documentation about how to use FastAPI label Feb 19, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 19, 2026

Merging this PR will not alter performance

✅ 20 untouched benchmarks


Comparing fix-max_digits-docstring (c5e31ae) with master (faee822)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (c441583) during the generation of this report, so faee822 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Areeb455

This comment was marked as resolved.

@YuriiMotov

This comment was marked as resolved.

@Areeb455

This comment was marked as resolved.

@YuriiMotov
Copy link
Copy Markdown
Member Author

YuriiMotov commented Feb 22, 2026

@Areeb455, this PR hasn't been merged yet. So, to check it you need to checkout to the branch of this PR (fix-max_digits-docstring).
If you do it, you will see that the docstrings are:
Maximum number of digits allowed for decimal values. and Maximum number of decimal places allowed for decimal values.

@Areeb455
Copy link
Copy Markdown

Thank you @YuriiMotov! I've reviewed the latest changes in the branch. The docstrings are now technically accurate and the wording is much clearer.

@svlandeg svlandeg merged commit 8b0090c into master Mar 4, 2026
31 checks passed
@svlandeg svlandeg deleted the fix-max_digits-docstring branch March 4, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants