Skip to content

👷 Always run tests on push to master branch and when run by scheduler#14940

Merged
tiangolo merged 2 commits intomasterfrom
always-run-tests-on-master
Feb 20, 2026
Merged

👷 Always run tests on push to master branch and when run by scheduler#14940
tiangolo merged 2 commits intomasterfrom
always-run-tests-on-master

Conversation

@YuriiMotov
Copy link
Member

@YuriiMotov YuriiMotov commented Feb 18, 2026

Currently we skip tests if there are no code changes.
But then in some cases smokeshow workflow fails on master branch with Artifact not found for name: coverage-html.

It results in:

image

or

image

To fix this we need to always run tests on push to master and when test workflow is run by scheduler

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 18, 2026

Merging this PR will not alter performance

✅ 20 untouched benchmarks


Comparing always-run-tests-on-master (944a501) with master (faee822)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (c441583) during the generation of this report, so faee822 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@YuriiMotov YuriiMotov marked this pull request as draft February 19, 2026 09:17
@YuriiMotov YuriiMotov marked this pull request as ready for review February 19, 2026 09:30
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 🚀

@tiangolo tiangolo merged commit cf05823 into master Feb 20, 2026
28 checks passed
@tiangolo tiangolo deleted the always-run-tests-on-master branch February 20, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants