-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
📝 Clarify estimation note in documentation #14070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Clarify estimation note in documentation #14070
Conversation
|
Note: The tag was kept intentionally for styling consistency. |
saky-semicolon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both sentences read well, but the second one (“conducted by”) is a bit clearer and more formal than the first. I’d suggest going with the second version for better readability.
|
I am new to contributions so |
This comment was marked as outdated.
This comment was marked as outdated.
svlandeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR @SaisakthiM! The rephrasing makes sense to me: IMO it's easier to parse & understand the sentence with this edit.
This comment was marked as outdated.
This comment was marked as outdated.
|
@SaisakthiM : as this is just a documentation PR, there's no need to merge in master when there are no conflicts. Thanks! |
can you explain it more clearly |
|
anyone here is the progress going on |
|
@YuriiMotov can you please review this |
It's already approved by Team member. Now we are waiting for final review by Sebastian |
tiangolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 📝
* Sync with #14217 * Sync with #14359 * Sync with #13786 * Sync with #14070 * Sync with #14120 * Sync with #14211 * Sync with #14405 * "to deploy" -> "deployen" The LLM used that translation a lot ithis convinced me that "deployen" it is the better word. "bereitstellen" (or "ausliefern") is still used for "to serve". --------- Co-authored-by: Motov Yurii <[email protected]> Co-authored-by: Yurii Motov <[email protected]>

Description
This PR improves the clarity of a documentation note inside a
<small>tag:Before:
* estimation based on tests on an internal development team, building production applications.
After:
* estimation based on tests conducted by an internal development team, building production applications.
The change corrects the wording to better describe the context while keeping the
<small>styling intact.Pull Request type
Notes
This is a minor documentation update and does not affect any code functionality.