Skip to content

Conversation

@SaisakthiM
Copy link
Contributor

Description

This PR improves the clarity of a documentation note inside a <small> tag:

  • Before:
    * estimation based on tests on an internal development team, building production applications.

  • After:
    * estimation based on tests conducted by an internal development team, building production applications.

The change corrects the wording to better describe the context while keeping the <small> styling intact.

Pull Request type

  • Documentation

Notes

This is a minor documentation update and does not affect any code functionality.

@SaisakthiM
Copy link
Contributor Author

SaisakthiM commented Sep 11, 2025

Note: The tag was kept intentionally for styling consistency.
This is a docs-only change; only the content inside the tag was corrected.
The CI flagged it as failing, but it does not affect the functionality or content of the documentation.

Copy link

@saky-semicolon saky-semicolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both sentences read well, but the second one (“conducted by”) is a bit clearer and more formal than the first. I’d suggest going with the second version for better readability.

@svlandeg svlandeg changed the title docs: clarify estimation note in docs 📝 Clarify estimation note in documentation Sep 12, 2025
@svlandeg svlandeg added the docs Documentation about how to use FastAPI label Sep 12, 2025
@svlandeg
Copy link
Member

The CI flagged it as failing, but it does not affect the functionality or content of the documentation.

It's always a good idea to go and read why the CI is failing 😉

In this case:

image

What this means, is that index.md should get the same edit.

@svlandeg svlandeg marked this pull request as draft September 12, 2025 10:06
@SaisakthiM SaisakthiM marked this pull request as ready for review September 21, 2025 05:35
@SaisakthiM
Copy link
Contributor Author

SaisakthiM commented Sep 21, 2025

I am new to contributions so
i didn't know the full idea of how CI/CD works
sorry for that
i changed the index.md just now
thanks for you help

@github-actions github-actions bot removed the waiting label Sep 21, 2025
@SaisakthiM SaisakthiM marked this pull request as draft September 21, 2025 05:37
@github-actions

This comment was marked as outdated.

@svlandeg svlandeg marked this pull request as ready for review September 22, 2025 16:48
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR @SaisakthiM! The rephrasing makes sense to me: IMO it's easier to parse & understand the sentence with this edit.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

@svlandeg
Copy link
Member

svlandeg commented Oct 3, 2025

@SaisakthiM : as this is just a documentation PR, there's no need to merge in master when there are no conflicts. Thanks!

@SaisakthiM
Copy link
Contributor Author

@SaisakthiM : as this is just a documentation PR, there's no need to merge in master when there are no conflicts. Thanks!

can you explain it more clearly
is my PR rejected

@SaisakthiM
Copy link
Contributor Author

anyone here is the progress going on

@SaisakthiM
Copy link
Contributor Author

SaisakthiM commented Nov 27, 2025

@YuriiMotov can you please review this
it is open for a month now

@YuriiMotov
Copy link
Member

@YuriiMotov can you please review this it is open for a month now

It's already approved by Team member. Now we are waiting for final review by Sebastian

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 📝

@tiangolo tiangolo merged commit cdafd64 into fastapi:master Dec 2, 2025
43 checks passed
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Dec 2, 2025
YuriiMotov added a commit that referenced this pull request Dec 2, 2025
* Sync with #14217

* Sync with #14359

* Sync with #13786

* Sync with #14070

* Sync with #14120

* Sync with #14211

* Sync with #14405

* "to deploy" -> "deployen"

The LLM used that translation a lot ithis convinced me that "deployen" it is the better word. "bereitstellen" (or "ausliefern") is still used for "to serve".

---------

Co-authored-by: Motov Yurii <[email protected]>
Co-authored-by: Yurii Motov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants