⚡️ Use TypeAdapter.validate_json instead of json.loads#13951
Open
dolfinus wants to merge 1 commit intofastapi:masterfrom
Open
⚡️ Use TypeAdapter.validate_json instead of json.loads#13951dolfinus wants to merge 1 commit intofastapi:masterfrom
TypeAdapter.validate_json instead of json.loads#13951dolfinus wants to merge 1 commit intofastapi:masterfrom
Conversation
a558ae5 to
3160247
Compare
TypeAdapter.validate_json for Pydantic v2
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
3160247 to
79b4288
Compare
Merging this PR will improve performance by 24.27%
Performance Changes
Comparing Footnotes |
Contributor
79b4288 to
05540da
Compare
TypeAdapter.validate_json for Pydantic v2TypeAdapter.validate_json instead of json.loads
fed22fa to
4a76701
Compare
4a76701 to
e26fe00
Compare
TypeAdapter.validate_json instead of json.loadsTypeAdapter.validate_json instead of json.loads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14962 replaced
json.dumpswith pydantic v2TypeAdapter.serialize_json(). This is the same, but for body parsing - replacejson.loadswithTypeAdapter.validate_json().See also #13949
Now this gives only a moderate speedup, nothing huge. The larger the request body, the larger the speedup.
Currently optimization can be applied only to POST handler with just one body field.
Small benchmark
requirements.txt
app.py
locustfile.py
Before - 2228RPS,

json.loadstook 9.8% andtype_adapter.validate_pythontook 1% = 10% combinedfastapi_with_json_loads.tar.gz
After - 2570RPS,

type_adapter.validate_jsontook 7.17%fastapi_with_typeadapter_json.tar.gz