🐛 Fix response status code which were misconfigured to show 403 #13729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reds Replaced 403 status code with 401 ; as 403 represents correct authentication but incorrect authorization. And the cases here are about missing creds in auth headers so 401 makes more sense. The response body is displaying the correct message but the response status code was 403.
AditSoni
changed the title
|
Looks good. A better practice is to use constants everywhere exceptions are created and asserts like HTTP_401_UNAUTHORIZED and INVALID_AUTH_CREDENTIALS_STR to avoid errors from typos. |
svlandeg
changed the title
Member
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced 403 status code with 401 ; as 403 represents correct authentication but incorrect authorization.
And the cases here are about missing creds in auth headers so 401 makes more sense.
The response body is displaying the correct message but the response status code was 403.