Skip to content

Update routing.py to handle circular references#11425

Closed
JavierSanchezCastro wants to merge 13 commits intofastapi:masterfrom
JavierSanchezCastro:master
Closed

Update routing.py to handle circular references#11425
JavierSanchezCastro wants to merge 13 commits intofastapi:masterfrom
JavierSanchezCastro:master

Conversation

@JavierSanchezCastro
Copy link
Contributor

From #11424

@JavierSanchezCastro JavierSanchezCastro marked this pull request as ready for review May 10, 2024 10:54
Copy link

@eljoserass eljoserass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JavierSanchezCastro JavierSanchezCastro closed this by deleting the head repository Sep 12, 2024
@connesy
Copy link

connesy commented Jun 26, 2025

Hi @JavierSanchezCastro

Sorry for pinging you on an old PR, but was this PR ever merged into FastAPI master? I ran into this exact issue today, and couldn't find your assert self is not router in the source code.

@JavierSanchezCastro
Copy link
Contributor Author

@connesy Hey, I think it got closed automatically because I made changes in my repo, I'll create another one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants