-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
🐛 Fix evaluating stringified annotations in Python 3.10 #11355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
009cce8
Fix evaluating stringified annotations in Python 3.10 (also from __fu…
chaen fd9034e
Merge branch 'master' into annotated
svlandeg 9b1cbc5
refactor unit test to avoid Python check twice
svlandeg 9157699
expand needs_py310 scope
svlandeg 9413db6
remove unnecessary login print
svlandeg 088b157
🔄 Merge branch 'master' into pr/chaen/11355
tiangolo 145d1de
♻️ Refactor test names and files to simplify
tiangolo a06dc7a
🔥 Remove test already passing on master, refactor and simplify remain…
tiangolo 61ef225
✅ Update tests
tiangolo 6b68de7
✅ Tweak Python 3.10-only test to not break below 3.10
tiangolo 8aae553
✅ Tweak tests
tiangolo fe32cb8
Merge branch 'master' into annotated
tiangolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from fastapi import Depends, FastAPI, Request | ||
| from fastapi.testclient import TestClient | ||
| from typing_extensions import Annotated | ||
|
|
||
| from .utils import needs_py310 | ||
|
|
||
|
|
||
| class Dep: | ||
| def __call__(self, request: Request): | ||
| return "test" | ||
|
|
||
|
|
||
| @needs_py310 | ||
| def test_stringified_annotations(): | ||
| app = FastAPI() | ||
|
|
||
| client = TestClient(app) | ||
|
|
||
| @app.get("/test/") | ||
| def call(test: Annotated[str, Depends(Dep())]): | ||
| return {"test": test} | ||
|
|
||
| response = client.get("/test") | ||
| assert response.status_code == 200 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes jupyverse crash with:
Which doesn't make sense to me, because
NoAuthStrategyis defined here and used in the same file.There is also fastapi-users involved, so I'm pinging @frankie567 here but I don't think there's anything wrong there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please share the full stacktrace and a reproducer script and how to run it?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, you can reproduce with:
And the stack trace is:
Details
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
from __future__ import annotationsin this file seems to solve the issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly seeing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#14464