Skip to content

🌐 Add German translation for docs/de/docs/advanced/custom-response.md#10624

Merged
alejsdev merged 12 commits intofastapi:masterfrom
nilslindemann:de/docs/advanced/custom-response.md
Jan 23, 2024
Merged

🌐 Add German translation for docs/de/docs/advanced/custom-response.md#10624
alejsdev merged 12 commits intofastapi:masterfrom
nilslindemann:de/docs/advanced/custom-response.md

Conversation

@nilslindemann
Copy link
Contributor

@nilslindemann nilslindemann commented Nov 11, 2023

advanced/response-directly.md (#10618)
advanced/additional-responses.md (#10626)

German translation progress

* Full translation
* In sync with current docs/en/docs/advanced/custom-response.md
* Google Translate used
* Manually checked
* Checked for errors using LanguageTool
@tiangolo
Copy link
Member

Copy link
Contributor

@fhabers21 fhabers21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the translation is good.
I proposed some adjustments, although many of them are a matter of taste.

@tiangolo
Copy link
Member

@nilslindemann
Copy link
Contributor Author

Danke @fhabers21 fürs Review. Ich habe nicht alles übernommen, wie Du schon gesagt hast, es ist größtenteils Geschmäckle. Ich mag etwa lieber "das" als "dies", es sei denn, "dies" ist präziser. Wenn es klar ist, was gemeint ist, bevorzuge ich auch "sie" statt "diese", ansonsten "diese".

@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

tiangolo commented Dec 1, 2023

@tiangolo
Copy link
Member

@tiangolo
Copy link
Member

@alejsdev alejsdev added the lang-all Translations label Jan 8, 2024
@alejsdev alejsdev added awaiting-review lang-de German translations labels Jan 8, 2024
@alejsdev alejsdev merged commit c3914a1 into fastapi:master Jan 23, 2024
@alejsdev
Copy link
Member

Thanks for your contribution! @nilslindemann 🎉

And thanks for the review @fhabers21 🔍🧐

@nilslindemann
Copy link
Contributor Author

Superb!

@nilslindemann nilslindemann deleted the de/docs/advanced/custom-response.md branch January 23, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-de German translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants