✏️ Update links in docs/en/docs/async.md and docs/zh/docs/async.md to make them relative#10498
Merged
tiangolo merged 4 commits intofastapi:masterfrom Oct 30, 2023
Merged
✏️ Update links in docs/en/docs/async.md and docs/zh/docs/async.md to make them relative#10498tiangolo merged 4 commits intofastapi:masterfrom
docs/en/docs/async.md and docs/zh/docs/async.md to make them relative#10498tiangolo merged 4 commits intofastapi:masterfrom
Conversation
Member
|
📝 Docs preview for commit 251f852 at: https://a5157a7b.fastapitiangolo.pages.dev |
Member
|
📝 Docs preview for commit ad386f1 at: https://2a6dad0f.fastapitiangolo.pages.dev |
Closed
Contributor
|
The fixes are correct, but
|
Contributor
Author
|
Ok fren. Let me check
…On Mon, 23 Oct 2023, 1:09 pm Nils Lindemann, ***@***.***> wrote:
The fixes are correct, but
- the resulting URLs are absolute, the doc server
<https://fastapi.tiangolo.com/contributing/#docs-for-tests> complains
about that in its console log. To make them relative, replace
/tutorial/dependencies/ with tutorial/dependencies/index.md and
/tutorial/dependencies/sub-dependencies/ with
tutorial/dependencies/sub-dependencies.md
- the links can also be fixed in the documents docs/em/docs/async.md
and docs/zh/docs/async.md.
—
Reply to this email directly, view it on GitHub
<#10498 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUUUDPJN5MUIMYPA6LWCWPLYAYQZZAVCNFSM6AAAAAA6LCX34OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGY2DONJXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
nilslindemann
pushed a commit
to nilslindemann/fastapi
that referenced
this pull request
Oct 23, 2023
Some of them may already have been fixed by fastapi#10498 (which actually inspired this PR)
Member
|
📝 Docs preview for commit 0f6f145 at: https://0dbdf476.fastapitiangolo.pages.dev |
Fixing the broken url for zh lang ✨
Member
|
📝 Docs preview for commit dfe1e39 at: https://059cfd30.fastapitiangolo.pages.dev |
tiangolo
changed the title
docs/en/docs/async.md and docs/zh/docs/async.md to make them relative
tiangolo
added
docs
Member
|
Thanks @hasnatsajid! 🚀 And thanks for the help @nilslindemann! 🙇 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated async.md for a url fix 🐛