Skip to content

FastAPI tests in pydantic failing due to flask deprecation #9467

@samuelcolvin

Description

@samuelcolvin

Privileged issue

  • I'm @tiangolo or he asked me directly to create an issue here.

Issue Content

hope you don't mind me creating an issue, pydantic's 1.10.X tests are failing due to a new issue with running our fastapi tests, see

https://github.com/pydantic/pydantic/actions/runs/4832692304/jobs/8611783607?pr=5628

output from pydantic's tests:

==================================== ERRORS ====================================
______ ERROR collecting tests/test_tutorial/test_wsgi/test_tutorial001.py ______
tests/test_tutorial/test_wsgi/test_tutorial001.py:3: in <module>
    from docs_src.wsgi.tutorial001 import app
docs_src/wsgi/tutorial001.py:3: in <module>
    from flask import Flask, escape, request
<frozen importlib._bootstrap>:1075: in _handle_fromlist
    ???
/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/site-packages/flask/__init__.py:71: in __getattr__
    warnings.warn(
E   DeprecationWarning: 'flask.escape' is deprecated and will be removed in Flask 2.4. Import 'markupsafe.escape' instead.
=========================== short test summary info ============================
ERROR tests/test_tutorial/test_wsgi/test_tutorial001.py - DeprecationWarning: 'flask.escape' is deprecated and will be removed in Flask 2.4. Import 'markupsafe.escape' 

related to pydantic/pydantic#5628

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions