fix(codex): restore cached tool call fields#4160
Merged
farion1231 merged 2 commits intoJun 16, 2026
Merged
Conversation
chen-985211
force-pushed
the
codex-chat-tool-call-history
branch
from
June 13, 2026 15:23
846325e to
da3510f
Compare
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
enrich_call_item_from_cache copied the fill-if-empty loop for reasoning_content/reasoning. The two loops are identical and key order is irrelevant, so fold both key sets into a single loop. Pure refactor, no behavior change; codex_chat_history tests pass.
farion1231
approved these changes
Jun 16, 2026
farion1231
left a comment
farion1231
left a comment
Owner
There was a problem hiding this comment.
Thank you for your contribution！
gfunc
pushed a commit
to gfunc/cc-switch
that referenced
this pull request
Jun 19, 2026
* fix(codex): restore cached tool call fields * refactor(codex): merge duplicate enrich loops in chat history enrich_call_item_from_cache copied the fill-if-empty loop for reasoning_content/reasoning. The two loops are identical and key order is irrelevant, so fold both key sets into a single loop. Pure refactor, no behavior change; codex_chat_history tests pass. --------- Co-authored-by: Jason <[email protected]>
This was referenced Jun 27, 2026
Closed
Closed
Closed
Closed
char1eslu
added a commit
to char1eslu/cc-switch
that referenced
this pull request
Jul 5, 2026
proxy 链路（3.16.4）： - farion1231#3817 转发前解压请求体（zstd）：新增 content_encoding 模块，Codex Desktop 登录态压缩请求体不再破坏代理 JSON 解析，压缩的错误响应体也一并解压 - farion1231#4583 Copilot/Codex OAuth 走全局代理：不再写死 Client::new() 绕过代理 - farion1231#4159 Chat 工具调用缺函数名则跳过（流式/非流式/legacy 三路，去掉 unknown_tool 回退） 凭据安全（3.16.4/3.16.5）： - 通用配置片段剥离全部凭据：extract_claude_common_config 改用 is_sensitive_config_key 模式匹配，剥掉任意 *_API_KEY/*_AUTH_TOKEN/*secret*/*token* - farion1231#4654 用量脚本凭据仅作显式覆盖：ProviderService add/update 归一化 + deeplink 导入 + 前端缓存失效 - codex_history_migration 探测 CODEX_SQLITE_HOME 环境变量 Claude MCP（3.16.4）： - farion1231#3431 自定义配置目录时 MCP 文件存到目录内（dir/.claude.json）， 默认 ~/.claude 仍用 ~/.claude.json；移除旧的"访问即拷贝"迁移 farion1231#4160/farion1231#4239/farion1231#4316 经核对 fork 3.16.3 基线已含，跳过。 farion1231#4654 provider/mod.rs 测试与 farion1231#3431 mcp_commands 集成测试因 fork UsageScript/McpApps 字段差异未移植，功能逻辑完整，待后续补测试。 Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
Related Issue / 关联 Issue
Fixes #4152
Screenshots / 截图
Checklist / 检查清单
pnpm typecheckpasses / 通过 TypeScript 类型检查pnpm format:checkpasses / 通过代码格式检查cargo clippypasses (if Rust code changed) / 通过 Clippy 检查（如修改了 Rust 代码）Verification / 验证
pnpm typecheckpnpm format:checkcargo fmt --checkcargo clippycargo test codex_chat_history