fix: protect skills during copy fallback#2791
Merged
farion1231 merged 1 commit intoMay 18, 2026
Merged
Conversation
rogerdigital
marked this pull request as ready for review
May 14, 2026 15:56
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
farion1231
approved these changes
May 18, 2026
farion1231
left a comment
Owner
There was a problem hiding this comment.
Thank you for your contribution!
dfbb
pushed a commit
to dfbb/cc-switch
that referenced
this pull request
May 20, 2026
royccai
pushed a commit
to royccai/cc-switch-mod
that referenced
this pull request
May 31, 2026
delta-lo
pushed a commit
to delta-lo/cc-switch-mod
that referenced
this pull request
May 31, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The sync path deleted the destination skill directory before attempting symlink creation. If symlink creation failed and fallback copy used an empty or invalid source directory, the previously working app skill directory had already been removed.
Validation
Fixes #2762