Skip to content

Python 3 support#62

Open
methane wants to merge 38 commits intofarcepest:masterfrom
methane:python3
Open

Python 3 support#62
methane wants to merge 38 commits intofarcepest:masterfrom
methane:python3

Conversation

@methane
Copy link
Copy Markdown
Collaborator

@methane methane commented Apr 18, 2014

This pull request is based on #31 and a lot of fix.

okin and others added 30 commits January 9, 2014 18:03
@okin
Improved support for Python 3.
b9aa053
@okin
Changing the way checks for the error code are made.
0773933
@msabramo
Remove MySQLdb/release.py from git
4d61517 
because it's generated from metadata.cfg

and because I keep getting annoying diffs because of newline differences
-- e.g.:

    $ git diff
    diff --git a/MySQLdb/release.py b/MySQLdb/release.py
    index 5c30a6c..4ce9412 100644
    --- a/MySQLdb/release.py
    +++ b/MySQLdb/release.py
    @@ -1,4 +1,4 @@
    -
    -__author__ = "Andy Dustman <[email protected]>"
    -version_info = (1,2,4,'final',1)
    -__version__ = "1.2.4"
    +
    +__author__ = "Andy Dustman <[email protected]>"
    +version_info = (1,2,4,'final',1)
    +__version__ = "1.2.4"
@msabramo
Support Python 2.7, 3.3, 3.4
283299a 
These are reasonably modern versions of Python that I think are worth
supporting for the planned 1.3.0 release.
@msabramo
tox.ini: Remove ipdb
7591a43 
It makes tests take longer to install deps and now causes this error on
Python < 2.7, because of IPython 2.0.0 requiring 2.7:

    ERROR: IPython requires Python Version 2.7 or above.
@methane
Some Python 3 C-API fixes.
5fc7131
@methane
Fix memory corruption on Python 3.
8b8444f
@methane
Fix getattr on result object.
690e5e9
@methane
Fix segfault on Python 2.
80f5a4a
@methane
Cleanup
2556226 
Remove macros for Python <2.6
@methane
Remove more macros for ancient Python.
c4d8948
@msabramo
Merge branch 'py3-capi' into py3.3support
613762c
@msabramo
Merge branch 'support_py27_to_py34' into py3.3support
a7720be
@msabramo
Merge branch 'remove_MySQLdb/release.py' into py3.3support
182011e
@msabramo
Handle types in a Python 3 friendly way
9440a0d
@msabramo
.travis.yml: Add py33 and py34 but allow fail
f8c046e
@methane
Fix escaping.
acc984c 
escape_string() -- only accepts bytes
string_literal() -- Use ASCII to encode str(o)
@methane
More fix
9cdef71
@methane
Random fixes.
382fb9f
@methane
Connection.literal() always returns str instance.
c66b43c
@methane
self of module-level function is not NULL on Python 3.
b5780d2
@methane
Call decoders with unicode when field is not str and bytes.
e8c1ebb
@methane
Fix some tests.
f188e0f
@methane
Fix segfault on Python 2.
5a66f79
@methane
Fix multiply by float.
4a6dde8
@methane
Fix calling Binary() with string.
67ecdc8
@methane
StandardError is removed from Python 3
67cf0a0
@methane
use_unicode=True by default on Python 3.
312f46d
@methane
Don't allow test fail on Python 3.3 and 3.4
b28d58b
@methane
Travis doesn't support Python 3.4 yet.
63e7052
@msabramo msabramo mentioned this pull request Apr 18, 2014
Closed
@farcepest
Copy link
Copy Markdown
Owner

farcepest commented Apr 18, 2014

I hope to have some time to review this and other pull requests this weekend. I'm in the process of moving and starting a new job over the next two weeks.

@methane
Copy link
Copy Markdown
Collaborator Author

methane commented Apr 28, 2014

I've created fork named mysqlclient.
I'm sorry about forking. I respect your long work.
But I can't wait because I'll be too busy to release including windows binaries.

I hope my fork is merged back like setuptools and distribute.

@haizaar
Copy link
Copy Markdown

haizaar commented Jun 24, 2014

Any update / plans on Python 3 support please?

@methane, I can not find any mysqlclient fork on your page. Should we better use this fork instead?

@methane
Copy link
Copy Markdown
Collaborator Author

methane commented Jun 24, 2014

@haizaar
See https://pypi.python.org/pypi/mysqlclient and https://github.com/PyMySQL/mysqlclient-python

@wldcordeiro
Copy link
Copy Markdown

wldcordeiro commented Jun 29, 2014

@farcepest Were you able to merge this PR?

@jdufresne
Copy link
Copy Markdown

jdufresne commented Sep 4, 2014

@farcepest Any update on merging this?

@dlitz dlitz mentioned this pull request Sep 11, 2014
Closed
@frewsxcv
Copy link
Copy Markdown

frewsxcv commented Sep 17, 2014

For those who need Python 3 support, I recommend this fork: https://github.com/PyMySQL/mysqlclient-python

@vikt0rs
Copy link
Copy Markdown

vikt0rs commented Oct 13, 2014

@farcepest any hope to get it merged?

@frewsxcv
Copy link
Copy Markdown

frewsxcv commented Oct 13, 2014

If you're looking for a working (and maintained!) fork of this library that supports Python 3, check out mysqlclient-python

This was referenced Jun 9, 2018
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@farcepest farcepest

Labels

bug enhancement

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

9 participants

@methane @farcepest @haizaar @wldcordeiro @jdufresne @frewsxcv @vikt0rs @okin @msabramo