log: avoid double hashing in SourceLocationHasher

Crypt-iQ · l0rinc · Crypt-iQ · commit b8e92fb3d413 · 2025-07-28T10:17:04.000-04:00
Co-Authored-By: l0rinc &lt;pap.lorinc@gmail.com&gt;
diff --git a/src/logging.h b/src/logging.h
@@ -46,10 +46,10 @@ struct SourceLocationHasher {
     size_t operator()(const std::source_location& s) const noexcept
     {
         // Use CSipHasher(0, 0) as a simple way to get uniform distribution.
-        return static_cast<size_t>(CSipHasher(0, 0)
-                                       .Write(std::hash<std::string_view>{}(s.file_name()))
-                                       .Write(s.line())
-                                       .Finalize());
+        return size_t(CSipHasher(0, 0)
+                      .Write(s.line())
+                      .Write(MakeUCharSpan(std::string_view{s.file_name()}))
+                      .Finalize());
     }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -46,10 +46,10 @@ struct SourceLocationHasher {`
`46`	`46`	`size_t operator()(const std::source_location& s) const noexcept`
`47`	`47`	`{`
`48`	`48`	`// Use CSipHasher(0, 0) as a simple way to get uniform distribution.`
`49`		`- return static_cast<size_t>(CSipHasher(0, 0)`
`50`		`- .Write(std::hash<std::string_view>{}(s.file_name()))`
`51`		`- .Write(s.line())`
`52`		`- .Finalize());`
	`49`	`+ return size_t(CSipHasher(0, 0)`
	`50`	`+ .Write(s.line())`
	`51`	`+ .Write(MakeUCharSpan(std::string_view{s.file_name()}))`
	`52`	`+ .Finalize());`
`53`	`53`	`}`
`54`	`54`	`};`
`55`	`55`