Skip to content

Disable gdlib#90

Merged
fangohr merged 6 commits intomainfrom
disable-gdlib
Mar 12, 2024
Merged

Disable gdlib#90
fangohr merged 6 commits intomainfrom
disable-gdlib

Conversation

@iamashwin99
Copy link
Copy Markdown
Collaborator

@iamashwin99 iamashwin99 commented Aug 14, 2023

We want to explicitly disable gdlib in order to avoid auto tools from picking it up from the system.

@iamashwin99 iamashwin99 requested a review from fangohr August 30, 2023 07:52
fangohr
fangohr requested changes Aug 30, 2023
View reviewed changes
Comment thread spack/package.py
Comment thread Dockerfile Outdated
@iamashwin99
Copy link
Copy Markdown
Collaborator Author

iamashwin99 commented Aug 30, 2023

Inorder to keep it simple I will proceed with disabling the gdlib

@fangohr
Copy link
Copy Markdown
Owner

fangohr commented Feb 28, 2024

Spack provides libgd - is that the gdlib that Octopus can use? If so, should we include it in the dependecies?

@iamashwin99
Copy link
Copy Markdown
Collaborator Author

iamashwin99 commented Feb 28, 2024

Spack provides libgd - is that the gdlib that Octopus can use? If so, should we include it in the dependecies?

spack providedlibgd (https://packages.spack.io/package.html?name=libgd) is indeed the same one octopus calls as "gdlib".

They plan to depreciate gdlib support (since the same could be now done via cgal) and hence we should skip supporting it for now.

@iamashwin99
Copy link
Copy Markdown
Collaborator Author

iamashwin99 commented Feb 28, 2024

rebased from main. (also refreshes the build logs)

@iamashwin99
Copy link
Copy Markdown
Collaborator Author

iamashwin99 commented Feb 28, 2024

The current failure on the develop seems to be due to octopus dropping support for berkeleygw@2

fangohr
fangohr reviewed Mar 11, 2024
View reviewed changes
Comment thread spack/package.py Outdated
@fangohr
Copy link
Copy Markdown
Owner

fangohr commented Mar 11, 2024

Currently fails because Octopus@develop needs BerkeleyGW 3. (MR for this is #101)

@iamashwin99
Copy link
Copy Markdown
Collaborator Author

iamashwin99 commented Mar 12, 2024 •
edited
Loading

Currently fails because Octopus@develop needs BerkeleyGW 3. (MR for this is #101)

Rebased to current main

@iamashwin99 @fangohr
Update spack/package.py
f5a80d0 
Co-authored-by: Hans Fangohr <[email protected]>
@iamashwin99 iamashwin99 requested a review from fangohr March 12, 2024 16:00
@fangohr fangohr merged commit beab598 into main Mar 12, 2024
@fangohr fangohr deleted the disable-gdlib branch March 12, 2024 17:04
@iamashwin99 iamashwin99 mentioned this pull request Mar 13, 2024
Closed
iamashwin99 added a commit that referenced this pull request Mar 17, 2024
@iamashwin99
update octopus package from spack upstream
ef4f0cb 
Includes changes from :
- spack/spack#41747
- spack/spack#41003
- spack/spack#41919
- spack/spack#40685
- Add hash for octopus 14 and Update BerkeleyGW dependency version in Octopus package #101 ( done at octopus: Support new version octopus@14  spack/spack#43160)
push changes in Disable gdlib #90 (done at octopus: disable gdlib by default spack/spack#43161)
- include new maintainer spack/spack#43163
@iamashwin99 iamashwin99 mentioned this pull request Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fangohr fangohr Awaiting requested review from fangohr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iamashwin99 @fangohr