Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): skip rules jobs when no rule is changed #72

Merged
merged 4 commits into from
Jun 1, 2023
Merged

fix(ci): skip rules jobs when no rule is changed #72

merged 4 commits into from
Jun 1, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Testing the CI, and fixing it to skip rules jobs when no ruleset is changed.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@poiana poiana requested review from darryk10 and leodido June 1, 2023 10:46
@jasondellaluce jasondellaluce force-pushed the fix/ci-issues-2 branch 2 times, most recently from e640dcb to 3be3730 Compare June 1, 2023 10:56
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

rules/falco_rules.yaml

Comparing 8cbdcc79f4545234bcad2a9cf788bf41ec4a9912 with latest tag falco-rules-0.1.0

Major changes:

  • List white_listed_modules has been removed
  • Rule Contact EC2 Instance Metadata Service From Container has been disabled at default
  • Rule Outbound Connection to C2 Servers has been disabled at default
  • Rule Java Process Class File Download has been disabled at default

Minor changes:

  • Required engine version was incremented from 13 to 17
  • Rule PTRACE anti-debug attempt has been added
  • Rule Drop and execute new binary in container has been added
  • Macro kernel_module_load has been added
  • Macro known_aks_mount_in_privileged_containers has been added
  • Macro ptrace_attach_or_injection has been added
  • List allowed_container_images_loading_kernel_module has been added
  • List python_package_managers has been added
  • List authorized_server_binary has been added
  • List known_drop_and_execute_containers has been added

Patch changes:

  • Rule Linux Kernel Module Injection Detected changed its output fields
  • Rule PTRACE attached to process matches more events than before
  • List docker_binaries has some item added or removed
  • List rpm_binaries has some item added or removed
  • List package_mgmt_binaries has some item added or removed
  • List safe_etc_dirs has some item added or removed
  • List falco_privileged_images has some item added or removed
  • List network_tool_binaries has some item added or removed
  • List user_known_k8s_ns_kube_system_images has some item added or removed

@jasondellaluce jasondellaluce changed the title wip: fix(ci): skip rules jobs when no rule is changed fix(ci): skip rules jobs when no rule is changed Jun 1, 2023
@jasondellaluce jasondellaluce force-pushed the fix/ci-issues-2 branch 2 times, most recently from a21a75b to c4c8557 Compare June 1, 2023 11:16
@jasondellaluce
Copy link
Contributor Author

This should be ready to go!

Andreagit97
Andreagit97 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 1, 2023
@poiana
Copy link

poiana commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jun 1, 2023

LGTM label has been added.

Git tree hash: 63a9636d44783c0fddbfad2f49ff75d402634b14

@poiana poiana merged commit 3e3dd21 into main Jun 1, 2023
@poiana poiana deleted the fix/ci-issues-2 branch June 1, 2023 11:18
@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@darryk10 darryk10 Awaiting requested review from darryk10

@leodido leodido Awaiting requested review from leodido

Assignees

@Andreagit97 Andreagit97

Labels
approved area/build dco-signoff: yes kind/bug Something isn't working lgtm size/M
Projects
None yet
Milestone
falco-rules-1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jasondellaluce @poiana @Andreagit97