Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conda as a package manager for Python that could be used #49

Merged
merged 1 commit into from
May 3, 2023

Conversation

pabloem
Copy link
Contributor

@pabloem pabloem commented Apr 18, 2023

Thanks to @edirgarcia for the idea : D

What type of PR is this?

/kind feature

The list of package managers does not include Conda, a common manager for Python packages and lower-level depenencies.

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Without this change, some package manager use cases may be missed,

Which issue(s) this PR fixes:

No issue included at the moment

Special notes for your reviewer:

@pabloem
Copy link
Contributor Author

pabloem commented Apr 18, 2023

fyi @aijamalnk

@poiana
Copy link

poiana commented Apr 18, 2023

Welcome @pabloem! It looks like this is your first PR to falcosecurity/rules 🎉

@poiana poiana requested review from Kaizhe and leodido April 18, 2023 14:37
@poiana poiana added the size/XS label Apr 18, 2023
Copy link
Member

@loresuso loresuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Apr 21, 2023

LGTM label has been added.

Git tree hash: c39c44f55730f29cfa9c68f24701f98b83bb3859

@pabloem
Copy link
Contributor Author

pabloem commented May 2, 2023

@poiana @aijamalnk I was wondering if there's anything else needed to merge this one?

@loresuso
Copy link
Member

loresuso commented May 2, 2023

cc @leogr

@poiana
Copy link

poiana commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, loresuso, pabloem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label May 3, 2023
@poiana poiana merged commit f773578 into falcosecurity:main May 3, 2023
@pabloem pabloem deleted the add-conda-pkg-manager branch May 8, 2023 18:30
@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants