Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README.md): clarifications and improvements #22

Merged
merged 1 commit into from
Jan 26, 2023
Merged

docs(README.md): clarifications and improvements #22

merged 1 commit into from
Jan 26, 2023

Conversation

leogr
Copy link
Member

@leogr leogr commented Jan 26, 2023

Signed-off-by: Leonardo Grasso [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Jan 26, 2023

@leogr: The label(s) kind/documentation, area/documentation cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Leonardo Grasso [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana requested review from Kaizhe and loresuso January 26, 2023 16:28
@leogr
Copy link
Member Author

leogr commented Jan 26, 2023

/kind documentation
/area documentation

@poiana poiana added kind/documentation Improvements or additions to documentation area/documentation labels Jan 26, 2023
jasondellaluce
jasondellaluce approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jan 26, 2023
@poiana
Copy link

poiana commented Jan 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3c1f203 into main Jan 26, 2023
@poiana poiana deleted the docs/improve-readme branch January 26, 2023 16:33
@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@loresuso loresuso Awaiting requested review from loresuso

Assignees

@jasondellaluce jasondellaluce

Labels
approved area/documentation dco-signoff: yes kind/documentation Improvements or additions to documentation lgtm size/S
Projects
None yet
Milestone
falco-rules-1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@leogr @poiana @jasondellaluce