Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ci): use an explicit role instead of a secret #21

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

LucaGuerra
Copy link
Contributor

Signed-off-by: Luca Guerra [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:

The role ARN is not a secret and does not allow any access by itself. However, adding it here explicitly makes it easier to troubleshoot potential issues.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The role ARN is not a secret and does not allow any access by itself. However, adding it here explicitly makes it easier to troubleshoot potential issues.

Signed-off-by: Luca Guerra <[email protected]>
@poiana
Copy link

poiana commented Jan 25, 2023

@LucaGuerra: The label(s) kind/cleanup, area/build cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Luca Guerra [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:

The role ARN is not a secret and does not allow any access by itself. However, adding it here explicitly makes it easier to troubleshoot potential issues.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jan 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 26, 2023

LGTM label has been added.

Git tree hash: afdb9e1972bf164ff9c21f82c7c7dbf3a3a0334b

@poiana poiana merged commit e9dc6b9 into main Jan 26, 2023
@poiana poiana deleted the LucaGuerra-ci-explicit-role branch January 26, 2023 08:03
@jasondellaluce
Copy link
Contributor

/milestone falco-rules-1.0.0

@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants