Skip to content

Conversation

@irozzo-1A
Copy link
Contributor

@irozzo-1A irozzo-1A commented Nov 18, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Partial revert of commit f1e38d4 to be able to support Falco libs 0.21

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Keeping PLUGIN_REQUIRED_EVENT_SCHEMA_VERSION=4.0.0 is a bit misleading, because the plugin still supports event schema version 3.x.x used by libs 0.21 and 0.20, but it's required because version 3.0.0 is assumed otherwise by libs >= 0.22. The tricks is that those libs version do not enforce the check yet.
The utility of keeping it is that it protects from using the plugins after an event schema version bump to 5.x.x.

@poiana poiana added the size/L label Nov 18, 2025
@irozzo-1A irozzo-1A force-pushed the container/downgrade-required-plugin-api-3.11 branch from cc6376c to d8ac317 Compare November 18, 2025 18:32
@poiana poiana added size/M and removed size/L labels Nov 18, 2025
@irozzo-1A irozzo-1A force-pushed the container/downgrade-required-plugin-api-3.11 branch from d8ac317 to 2f119bf Compare November 19, 2025 07:57
@github-actions
Copy link

Rules files suggestions

Partial revert of commit f1e38d4 to be
able to support Falco libs 0.21

Signed-off-by: Iacopo Rozzo <[email protected]>
@irozzo-1A irozzo-1A force-pushed the container/downgrade-required-plugin-api-3.11 branch from 2f119bf to 3388c33 Compare November 19, 2025 08:54
@github-actions
Copy link

Rules files suggestions

@irozzo-1A irozzo-1A marked this pull request as ready for review November 19, 2025 09:16
@poiana
Copy link
Contributor

poiana commented Nov 19, 2025

LGTM label has been added.

DetailsGit tree hash: 68dae4fd24ecac004be5b5c10c748fe538d78ca1

@poiana
Copy link
Contributor

poiana commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irozzo-1A, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cb0d70b into falcosecurity:main Nov 19, 2025
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants