Skip to content

Conversation

@leogr
Copy link
Member

@leogr leogr commented Apr 29, 2020

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1171

Special notes for your reviewer:
/cc @leodido
I used falcosecurity/falco:${FALCO_VERSION} as the base image in order to re-use the stable dockerfile and avoid duplication of code.

Does this PR introduce a user-facing change?:

N.B.: release-note has been added here 👉 #1192

NONE

@leogr leogr force-pushed the new/driverloader branch from b4afb3e to 410a9f1 Compare April 30, 2020 07:41
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions @leogr

@leodido
Copy link
Member

leodido commented Apr 30, 2020

/milestone 0.23.0

@leodido leodido added this to the 0.23.0 milestone Apr 30, 2020
@leodido leodido self-requested a review April 30, 2020 10:41
Co-authored-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
@leogr
Copy link
Member Author

leogr commented Apr 30, 2020

Left some suggestions @leogr

Done 👍 pls check it out again

@poiana
Copy link
Contributor

poiana commented May 4, 2020

LGTM label has been added.

DetailsGit tree hash: 46b4bfaf806af779242134624e9a52819e786787

@poiana poiana added the approved label May 4, 2020
@leogr leogr changed the title wip: driverloader docker image driverloader docker image May 4, 2020
@poiana
Copy link
Contributor

poiana commented May 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

falcosecurity/driverloader docker image

5 participants