fix: add an "or" condition for configmap-ui #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Hassan <[email protected]>
poiana
added
dco-signoff: yes
kind/bug
|
Welcome @Aliloya-eng! It looks like this is your first PR to falcosecurity/charts 🎉 |
IgorEulalio
reviewed
Mar 26, 2025
Co-authored-by: Igor Eulalio <[email protected]> Signed-off-by: Aliloya <[email protected]>
Aliloya-git
changed the title
Signed-off-by: Aliloya <[email protected]>
leogr
approved these changes
Mar 27, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Aliloya-eng, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: aed465ccef56de7b79337042d55424bf7f6e68e4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind chart-release
/area falcosidekick-chart
What this PR does / why we need it:
Fixes #856
Which issue(s) this PR fixes:
Fixes #856
Special notes for your reviewer:
I am not an expert so please verify the issue, review my PR carefully, and let me know if you have any feedback/comment for me.
Thank you for your review in advance :)
Checklist