fix container engines sockets #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
This commit fixes a bug that had the socket paths hardcoded in the volumeMounts. Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
alacuku
force-pushed
the
kcl/container-engines-sockets
branch
from
a351a54 to
9067045
Compare
|
/unhold |
Issif
approved these changes
Feb 14, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: d67bb54cd28027940cff1a4f65ff4f4e727db1e1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
This PR removes the
hardcodedvalues for container engines involumeMountsand uses the values from the values.yaml file instead.Which issue(s) this PR fixes:
#840
Fixes #
Special notes for your reviewer:
I've already fixed the corrisponding labels in GitHub
Checklist