Add country_code to Estonia locale (locales/ee.yml)#3111
Merged
thdaraujo merged 1 commit intofaker-ruby:mainfrom Nov 16, 2025
Merged
Add country_code to Estonia locale (locales/ee.yml)#3111thdaraujo merged 1 commit intofaker-ruby:mainfrom
country_code to Estonia locale (locales/ee.yml)#3111thdaraujo merged 1 commit intofaker-ruby:mainfrom
Conversation
thdaraujo
force-pushed
the
issue-3098-add-ee-country-code
branch
from
a7efcd5 to
cb456b2
Compare
thdaraujo
requested changes
Nov 11, 2025
test/test_ee_locale.rb
Outdated
| def test_ee_cell_phone_with_country_code | ||
| phone_number = Faker::PhoneNumber.phone_number_with_country_code | ||
|
|
||
| assert_match /\+372\s?\d{3}\s?\d{4}/, phone_number |
Contributor
There was a problem hiding this comment.
[Correctable] Lint/AmbiguousRegexpLiteral: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.
assert_match /\+372\s?\d{3}\s?\d{4}/, phone_number
HassanAkbar
force-pushed
the
issue-3098-add-ee-country-code
branch
2 times, most recently
from
5e64d86 to
65b13d3
Compare
HassanAkbar
force-pushed
the
issue-3098-add-ee-country-code
branch
from
65b13d3 to
2c9e046
Compare
thdaraujo
changed the title
country_code to Estonia locale (locales/ee.yml)
thdaraujo
approved these changes
Nov 16, 2025
Contributor
thdaraujo
left a comment
thdaraujo
left a comment
There was a problem hiding this comment.
excellent, thank you! 🙏
stefannibrasil
pushed a commit
that referenced
this pull request
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3098
This Pull Request adds
country_codeto Estonia.For Germany, its working as expected e.g,
It returns
+49which is an expected behavior.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: