Skip to content

Add Artist translations for the japanese locale#3110

Merged
thdaraujo merged 1 commit intofaker-ruby:mainfrom
neco-nico:add-ja-locals-for-artist
Nov 2, 2025
Merged

Add Artist translations for the japanese locale#3110
thdaraujo merged 1 commit intofaker-ruby:mainfrom
neco-nico:add-ja-locals-for-artist

Conversation

@neco-nico
Copy link
Contributor

@neco-nico neco-nico commented Aug 9, 2025 •
edited
Loading

Motivation / Background

This Pull Request has been created to add new locale data for Japanese artists names to this library.

Additional information

I have written the notation based mainly on a database of The Art Library Consortium which aims at supporting studies on art and art-related fields by promoting access to art research resources in Japan.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

@neco-nico neco-nico force-pushed the add-ja-locals-for-artist branch from 1e1a19d to 10d12b5 Compare August 9, 2025 16:50
@neco-nico neco-nico marked this pull request as ready for review August 9, 2025 16:56
@neco-nico
Copy link
Contributor Author

neco-nico commented Aug 10, 2025

I ran bundle exec rake console to confirm the translations are working as expected.

irb(main):001:0> Faker::Config.locale = :ja
=> :ja
irb(main):002:0> Faker::Artist.name
=> "ドガ"

thdaraujo
thdaraujo approved these changes Nov 2, 2025
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thank you!

@thdaraujo thdaraujo changed the title Add Japanese translation for the "Artist" category Add "Artist" translations for the japanese locale Nov 2, 2025
@thdaraujo thdaraujo changed the title Add "Artist" translations for the japanese locale Add Artist translations for the japanese locale Nov 2, 2025
@thdaraujo thdaraujo merged commit 0fe0b21 into faker-ruby:main Nov 2, 2025
stefannibrasil pushed a commit that referenced this pull request Jan 8, 2026
@neco-nico @stefannibrasil
Add Japanese translation for the "Artist" category (#3110)
b6d7955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neco-nico @thdaraujo