Add mountains to de-CH locale#3066
Merged
thdaraujo merged 1 commit intofaker-ruby:mainfrom Jul 1, 2025
Merged
Conversation
thdaraujo
reviewed
May 4, 2025
lib/locales/de-CH.yml
Outdated
| - Megaparsec | ||
| mountain: | ||
| name: | ||
| - Albis |
Contributor
There was a problem hiding this comment.
Do you mind narrowing the list down to maybe 10-15 options?
We don't need to provide every possible option, and this would also impact locale loading time.
thdaraujo
reviewed
May 4, 2025
Contributor
Author
|
@thdaraujo There you go. I guess it's really difficult to find a good balance between enough variation, a vast amount of topics and acceptable loading times. |
stefannibrasil
pushed a commit
that referenced
this pull request
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the mountains generator only includes Asian and American mountains. Hereby we add a list of mountains in the Swiss alps specifically for the de-CH locale.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]