Correct Faker::Address.city and Faker::Address.street_address for :fr locale#3018
Conversation
|
hi @brupla6126 do you mind running this formatter first? https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#yaml-files without this format, it's really hard to review this. This is one of the files that are missing this reformat. Thank you! |
brupla6126
force-pushed
the
fix_fr_address_city_and_street_translations
branch
from
b651d6c to
55fad8c
Compare
Hey @stefannibrasil I formatted the file but I noticed that many other locale files are unformatted. Maybe a rake task that will format all locale files at once? |
|
@stefannibrasil Is this gem still maintained ? Many PRs waiting in line... Maybe add more maintainers ? |
thdaraujo
changed the title
Faker::Address.city and Faker::Address.street_address for :fr locale
|
Thank you @thdaraujo. I am back from a long vacation. Thanks! |
4 participants
Motivation / Background
Our Rails app test suite validations are frequently failing when using :fr locale due to
1 - Numbers in city names
2 - Extra space in street names
Faker::Address.city
Faker::Address.street_address