Update dog breed names for en-US locale#2972
Merged
thdaraujo merged 2 commits intofaker-ruby:mainfrom Jul 9, 2024
Merged
Conversation
en-US locale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
I started this PR from noticing data generated from
Faker::Creature::Dog.breedhadAfricanas a dog breed. This is not a valid dog breed from searching online. There is a breed called Africanis, so I have updated this entry to that.While updating this value, I noticed some other names that could be cleaned up such as
Stbernardbeing updated toSaint Bernard. I also noted that the docs state to use dash syntax, so I formatted the file first so that it would be easy to follow the name changes.Additional information
I used https://en.wikipedia.org/wiki/List_of_dog_breeds as a reference. I did not change every inconsistency compared to these wiki names. For example, "Irish Spaniel" is not an entry on the wiki. I mostly tried to target errors and typos.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: