fix: Faker::Internet.username should not generate duplicated punctuation#2970
Merged
fix: Faker::Internet.username should not generate duplicated punctuation#2970
Faker::Internet.username should not generate duplicated punctuation#2970Conversation
thdaraujo
changed the title
Faker::Internet.username should not generate duplicated punctuation
thdaraujo
force-pushed
the
ta/fix-email-dot-separator
branch
from
db9afa9 to
6412563
Compare
stefannibrasil
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[fixes #2967]
In #2950 there was a change on how email usernames were generated. This caused usernames to be generated with duplicate punctuation - for example:
This PR restores the previous behavior when dealing with punctuation.
While we can't guarantee that any of these generated emails will be valid, we can restore the previous behaviour.